fix(websocket): support open diagnostics over h2#4921
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4921 +/- ##
=======================================
Coverage 92.90% 92.91%
=======================================
Files 112 112
Lines 35646 35660 +14
=======================================
+ Hits 33117 33133 +16
+ Misses 2529 2527 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KhafraDev
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix WebSocket open diagnostics for HTTP/2 connections.
WebSocket over HTTP/2 was already implemented, but subscribing to
undici:websocket:opencould crash the connection setup because the diagnostics payload assumed the transport always exposedsocket.address(). Over HTTP/2 the transport is a stream, so the address needs to be resolved from the underlying session socket.Changes
Testing
npx eslint lib/web/websocket/websocket.js lib/core/diagnostics.js test/websocket/diagnostics-channel-handshake-response-h2.jsnpm run test:websocket