chore: use Promise.withResolvers in SOCKS5 proxy agent

[trivikr]

This relates to...

Follow-up to #4972 which replaced createDeferredPromise with Promise.withResolvers()

Rationale

This PR narrows a broader Promise.withResolvers() refactor down to the places where it is most useful in the SOCKS5 proxy flow.

The initial change applied the pattern across several async helpers, but the follow-up commits intentionally restored the simpler new Promise(...) form in lower-value cases to avoid overhead. The resulting PR focuses on the SOCKS5 proxy agent, where separating promise creation from event wiring makes the connection/authentication/TLS flow easier to follow.

Changes

• Refactor the SOCKS5 proxy socket connection flow to use Promise.withResolvers()
• Refactor the SOCKS5 authentication wait path to use Promise.withResolvers()
• Refactor the SOCKS5 tunnel connection wait path to use Promise.withResolvers()
• Refactor the TLS upgrade wait path for HTTPS-over-SOCKS connections to use Promise.withResolvers()

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

• I have read and agreed to the Developer's Certificate of Origin
• Tested
• Benchmarked (optional)
• Documented
• Review ready
• In review
• Merge ready

[mcollina]

Most of those are not useful in making the code more readable and they add more overhead (destructuring costs) but the socks5 changes are ok

[codecov-commenter]

Codecov Report

❌ Patch coverage is 82.35294% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.94%. Comparing base (6a30f74) to head (25d35dc).

Files with missing lines	Patch %	Lines
lib/dispatcher/socks5-proxy-agent.js	82.35%	12 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4978   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files         110      110           
  Lines       35767    35773    +6     
=======================================
+ Hits        33244    33251    +7     
+ Misses       2523     2522    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

lgtm