fix(fetch): correct 'navigator' typo to 'navigate' in fetchFinale#5044
fix(fetch): correct 'navigator' typo to 'navigate' in fetchFinale#5044KhafraDev merged 1 commit intonodejs:mainfrom
Conversation
The condition in step 7 of fetchFinale checked `fetchParams.request.mode !== 'navigator'`, but 'navigator' is not a valid request mode — the spec value is 'navigate'. Because the typo never matched, the guarded block always ran, setting responseStatus and extracting the MIME type even for navigate-mode responses with cross-origin redirects, which the spec requires to be skipped. Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
KhafraDev
left a comment
There was a problem hiding this comment.
looks correct, is it possible to add a test?
|
@KhafraDev The autofix status said this:
|
KhafraDev
left a comment
There was a problem hiding this comment.
"navigate"
This is a special mode used only when navigating between documents.
it is correct
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5044 +/- ##
==========================================
- Coverage 93.03% 93.03% -0.01%
==========================================
Files 110 110
Lines 35793 35793
==========================================
- Hits 33301 33299 -2
- Misses 2492 2494 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The condition in step 7 of fetchFinale checked
fetchParams.request.mode !== 'navigator', but 'navigator' is not a valid request mode — the spec value is 'navigate'. Because the typo never matched, the guarded block always ran, setting responseStatus and extracting the MIME type even for navigate-mode responses with cross-origin redirects, which the spec requires to be skipped.