fix: reject malformed content-length request headers#5060
Merged
mcollina merged 3 commits intonodejs:mainfrom Apr 19, 2026
Merged
fix: reject malformed content-length request headers#5060mcollina merged 3 commits intonodejs:mainfrom
mcollina merged 3 commits intonodejs:mainfrom
Conversation
Assisted-by: openai:gpt-5.4 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5060 +/- ##
==========================================
- Coverage 93.10% 93.09% -0.01%
==========================================
Files 110 110
Lines 35770 35788 +18
==========================================
+ Hits 33303 33318 +15
- Misses 2467 2470 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5059
Rationale
content-lengthwas being validated too loosely because malformed values could be partially normalized before later request-body length checks.This change makes the header validation stricter so only digit-only values are accepted during request parsing.
Changes
content-lengthvalues before parsing them.content-lengthvalues.Features
N/A
Bug Fixes
Request
content-lengthmalformed values are rejected withInvalidArgumentError('invalid content-length header')instead of being normalized or deferred into a later mismatch error.Breaking Changes and Deprecations
Requests that previously accepted malformed
content-lengthvalues will now fail immediately during header validation.Status