fix(http2): reject upgrade streams closed before response headers#5069
Merged
mcollina merged 4 commits intonodejs:mainfrom Apr 21, 2026
Merged
fix(http2): reject upgrade streams closed before response headers#5069mcollina merged 4 commits intonodejs:mainfrom
mcollina merged 4 commits intonodejs:mainfrom
Conversation
Member
|
CI is very red |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5069 +/- ##
==========================================
+ Coverage 93.09% 93.11% +0.01%
==========================================
Files 110 110
Lines 35801 35818 +17
==========================================
+ Hits 33330 33351 +21
+ Misses 2471 2467 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
97e7827 to
0e144eb
Compare
Member
Author
|
The CI failures caused by timeouts in |
5ee2fce to
7338e9b
Compare
Assisted-by: openai:gpt-4.5 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
7338e9b to
2eced88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5064
Rationale
The H2 upgrade paths only advanced the request once a
responseevent arrived.If the peer closed the stream before sending headers, the request was never settled and the queue slot was not released, which could leave the operation hanging and interfere with later cleanup.
Changes
lib/dispatcher/client-h2.jssession.request(...)error,end, orcloseFeatures
N/A
Bug Fixes
CONNECTpathclient.close()does not wait on a stuck upgrade/connect requestBreaking Changes and Deprecations
N/A
Status