fix(http2): reject websocket upgrades on non-200 responses#5072
Merged
mcollina merged 1 commit intonodejs:mainfrom Apr 20, 2026
Merged
fix(http2): reject websocket upgrades on non-200 responses#5072mcollina merged 1 commit intonodejs:mainfrom
mcollina merged 1 commit intonodejs:mainfrom
Conversation
Assisted-by: openai:gpt-5.4 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5072 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 110 110
Lines 35799 35805 +6
=======================================
+ Hits 33329 33337 +8
+ Misses 2470 2468 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5063
Rationale
client.upgrade()over HTTP/2 currently asserts when a websocket extended CONNECT request receives a non-200response.That assertion escapes the normal request error path and crashes the process instead of rejecting the upgrade promise.
Changes
SocketError('bad upgrade')abort in the upgrade handler101) and H2 (200)Features
N/A
Bug Fixes
200responses instead of throwing an uncaught assertionBreaking Changes and Deprecations
N/A
Status