Skip to content

fix(http2): record ping failures on the socket#5075

Merged
mcollina merged 1 commit intonodejs:mainfrom
trivikr:h2-ping-failures-record
Apr 21, 2026
Merged

fix(http2): record ping failures on the socket#5075
mcollina merged 1 commit intonodejs:mainfrom
trivikr:h2-ping-failures-record

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented Apr 20, 2026

This relates to...

N/A

Rationale

HTTP/2 ping failures were being recorded on the Client object instead of the underlying socket.

That meant the connection state did not retain the ping error in the place later session/socket shutdown paths expect to read it from.

Changes

Fix the HTTP/2 ping callback to store ping errors on session[kSocket]

Features

N/A

Bug Fixes

  • Fix incorrect error recording for HTTP/2 ping failures
  • Preserve ping failure state for later close/disconnect handling

Breaking Changes and Deprecations

N/A

Status

Assisted-by: openai:gpt-5.4
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.13%. Comparing base (f6c5dda) to head (4f4fa69).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5075      +/-   ##
==========================================
+ Coverage   93.10%   93.13%   +0.03%     
==========================================
  Files         110      110              
  Lines       35799    35799              
==========================================
+ Hits        33329    33342      +13     
+ Misses       2470     2457      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from metcoder95 April 20, 2026 06:36
@mcollina mcollina merged commit aa59a02 into nodejs:main Apr 21, 2026
35 checks passed
@trivikr trivikr deleted the h2-ping-failures-record branch April 21, 2026 15:19
@github-actions github-actions Bot mentioned this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants