fix(websocket): avoid double-closing canceled stream readers#5105
Merged
tsctx merged 1 commit intonodejs:mainfrom Apr 24, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5105 +/- ##
==========================================
+ Coverage 93.13% 93.15% +0.01%
==========================================
Files 110 110
Lines 35826 35826
==========================================
+ Hits 33368 33375 +7
+ Misses 2458 2451 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tsctx
approved these changes
Apr 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Closes #5103
Closes #5104
Rationale
WebSocketStreamcould throwERR_INVALID_STATEwhenreadable.cancel()closed the internal controller before the later clean-close path tried to close it again. This keeps the readable shutdown path idempotent and prevents the uncaught exception.Changes
readableStreamClose()in the cleanWebSocketStreamsocket close path instead of callingReadableStreamDefaultController.close()directlyFeatures
N/A
Bug Fixes
WebSocketStreamdouble-close path that could throwTypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closedBreaking Changes and Deprecations
N/A
Status