fix(cache): enforce sqlite maxCount after insert#5112
Merged
mcollina merged 2 commits intonodejs:mainfrom Apr 27, 2026
Merged
Conversation
Assisted-by: openai:gpt-5.4 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5112 +/- ##
=======================================
Coverage 93.14% 93.14%
=======================================
Files 110 110
Lines 36117 36117
=======================================
Hits 33642 33642
Misses 2475 2475 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcollina
pushed a commit
that referenced
this pull request
Apr 29, 2026
(cherry picked from commit 2eb9ddc)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5111
Rationale
SqliteCacheStore#set()pruned before inserting a new row, and#prune()returned early whensize <= maxCount. That meant a store already at capacity accepted one more entry and only pruned on a later write. This change makesmaxCountenforcement happen after insert so the store does not remain oversized.Changes
Move SQLite cache pruning to run after inserting a new entry.
Features
N/A
Bug Fixes
Fix
SqliteCacheStoreallowing one extra cached row beyond maxCount.Breaking Changes and Deprecations
N/A
Status
Assisted-by: openai:gpt-5.4