fix: reuse parser WeakRef for timeout callbacks#5125
Merged
mcollina merged 2 commits intonodejs:mainfrom Apr 27, 2026
Merged
Conversation
Assisted-by: openai:gpt-5.5 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5125 +/- ##
==========================================
- Coverage 93.14% 93.13% -0.01%
==========================================
Files 110 110
Lines 35908 36105 +197
==========================================
+ Hits 33446 33627 +181
- Misses 2462 2478 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcollina
reviewed
Apr 27, 2026
|
|
||
| t.strictEqual(weakRefCount, 1) | ||
| } finally { | ||
| global.WeakRef = OriginalWeakRef |
Member
There was a problem hiding this comment.
instead of a try/catch, use t.after
mcollina
pushed a commit
that referenced
this pull request
Apr 29, 2026
(cherry picked from commit ead8a6b)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
N/A
Rationale
Parser#setTimeout()created a newWeakRefeach time it replaced a timeout callback.The parser instance is stable for the socket lifetime, so the same
WeakRefcan be reused instead of allocating a new one for every timeout replacement.Changes
WeakRefonParserconstruction.WeakReffor both fast timer and native timer timeout callbacks.Features
N/A
Bug Fixes
Avoid repeated
WeakRefallocations when replacing parser timeout callbacks.Breaking Changes and Deprecations
N/A
Status
Assisted-by: openai:gpt-5.5