Skip to content

fix: validate H2CClient maxConcurrentStreams option#5143

Merged
metcoder95 merged 1 commit intonodejs:mainfrom
trivikr:h2c-client-max-concurrent-streams
May 1, 2026
Merged

fix: validate H2CClient maxConcurrentStreams option#5143
metcoder95 merged 1 commit intonodejs:mainfrom
trivikr:h2c-client-max-concurrent-streams

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented May 1, 2026

This relates to...

Fixes: #5142

Rationale

H2CClient previously only applied maxConcurrentStreams when the value was valid.
Invalid user-provided values were replaced with the default instead of throwing like Client does.

Changes

Validate H2CClient maxConcurrentStreams values and throw InvalidArgumentError for invalid input.

Features

N/A

Bug Fixes

Validate H2CClient maxConcurrentStreams option

Breaking Changes and Deprecations

Should this be considered as a breaking change?
Although the types do not call it out, the value is expected to be a positive integer.

Status

Assisted-by: openai:gpt-5.5

Assisted-by: openai:gpt-5.5
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.21%. Comparing base (96fd5e9) to head (dc0c177).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5143   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files         110      110           
  Lines       36247    36247           
=======================================
  Hits        33787    33787           
  Misses       2460     2460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metcoder95 metcoder95 merged commit abb9d06 into nodejs:main May 1, 2026
35 checks passed
@github-actions github-actions Bot mentioned this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

H2CClient silently ignores invalid concurrency options instead of surfacing configuration errors

3 participants