fix: replace stale pool clients under connection limit#5145
Merged
mcollina merged 1 commit intonodejs:mainfrom May 1, 2026
Merged
fix: replace stale pool clients under connection limit#5145mcollina merged 1 commit intonodejs:mainfrom
mcollina merged 1 commit intonodejs:mainfrom
Conversation
Assisted-by: openai:gpt-5.5 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5145 +/- ##
==========================================
+ Coverage 93.21% 93.24% +0.03%
==========================================
Files 110 110
Lines 36247 36249 +2
==========================================
+ Hits 33787 33801 +14
+ Misses 2460 2448 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
May 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5144
Rationale
Expired clients were closed asynchronously but remained in
this[kClients]until close completed.With
connections: 1, that stale client still counted against the connection limit, so the pool could refuse to create a replacement and queue the request with no usable client left to drain it.Changes
PoolandRoundRobinPooldispatcher selection to handle stale-client removal during iteration.Features
N/A
Bug Fixes
Replace stale pool clients under connection limit
Breaking Changes and Deprecations
N/A
Status
Assisted-by: openai:gpt-5.5