test: fix flaky permessage-deflate limit timeout#5229
Merged
metcoder95 merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5229 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 110 110
Lines 36353 36353
=======================================
+ Hits 33907 33909 +2
+ Misses 2446 2444 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trivikr
approved these changes
May 6, 2026
metcoder95
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a flaky websocket test introduced by the
maxPayloadSize: 0coverage.The timeout path was calling
t.fail(...), which is not available on thenode:testcontext used here, so timeouts surfaced asTypeError: t.fail is not a functioninstead of a normal assertion failure.This also reduces the test payload from 100 MB to 2 MB so the "limit disabled" case still exercises a payload above the smaller limits used elsewhere in the file without depending on a slow transfer in CI.
Fixes: #5185
Validation
./node_modules/.bin/borp -p "test/websocket/permessage-deflate-limit.js"npm run lint -- --fix-dry-run test/websocket/permessage-deflate-limit.js