fix: handle paused parser on socket end (issue #5360)#5389
Merged
Conversation
Remove assert(!this.paused) from Parser.finish() so that when the HTTP/1 parser is paused under backpressure (body not consumed) and the socket ends (FIN), the parser can finish gracefully instead of throwing an uncatchable AssertionError from the socket 'end' handler. llhttp_finish() already handles paused state by returning ERROR.PAUSED, which is handled in the existing code path by setting this.paused = true and returning null. Fixes nodejs#5360
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5389 +/- ##
==========================================
+ Coverage 93.24% 93.27% +0.03%
==========================================
Files 110 110
Lines 36719 36751 +32
==========================================
+ Hits 34238 34279 +41
+ Misses 2481 2472 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ronag
approved these changes
Jun 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove assert(!this.paused) from Parser.finish() so that when the HTTP/1
parser is paused under backpressure (body not consumed) and the socket
ends (FIN), the parser can finish gracefully instead of throwing an
uncatchable AssertionError from the socket 'end' handler.
llhttp_finish() already handles paused state by returning ERROR.PAUSED,
which is handled in the existing code path by setting this.paused = true
and returning null.
Fixes #5360