Skip to content

test: fail on unexpected reconnect disconnect#5412

Merged
metcoder95 merged 1 commit into
nodejs:mainfrom
vibhor-aggr:test/reconnect-disconnect-assertion
Jun 18, 2026
Merged

test: fail on unexpected reconnect disconnect#5412
metcoder95 merged 1 commit into
nodejs:mainfrom
vibhor-aggr:test/reconnect-disconnect-assertion

Conversation

@vibhor-aggr

Copy link
Copy Markdown
Contributor

Summary

  • make the reconnect regression fail if the client emits an extra unexpected disconnect
  • keep the existing expected first disconnect assertion intact

Refs: #251

Verification

  • ./node_modules/.bin/borp --timeout 180000 --expose-gc -p test/client-reconnect.js
  • npm run lint -- test/client-reconnect.js
  • git diff --check

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.24%. Comparing base (ac5394b) to head (cb34bac).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5412      +/-   ##
==========================================
- Coverage   93.25%   93.24%   -0.01%     
==========================================
  Files         110      110              
  Lines       36825    36825              
==========================================
- Hits        34340    34339       -1     
- Misses       2485     2486       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metcoder95 metcoder95 merged commit 56bb5a0 into nodejs:main Jun 18, 2026
38 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants