Skip to content

fix(fs-access-mode-constants): don't modify other thing#382

Merged
AugustinMauroy merged 12 commits into
mainfrom
fix-fs-balbala
Jul 2, 2026
Merged

fix(fs-access-mode-constants): don't modify other thing#382
AugustinMauroy merged 12 commits into
mainfrom
fix-fs-balbala

Conversation

@AugustinMauroy

Copy link
Copy Markdown
Member

Description

Alex (codemod) reported that this codemod make changes on other file.

So:

  • I change tests file name for better understanding
  • I refracto to use more utility in goal of reducing complexity

@AugustinMauroy AugustinMauroy requested a review from a team March 6, 2026 08:36
@AugustinMauroy AugustinMauroy added the awaiting reviewer Author has responded and needs action from the reviewer label Mar 6, 2026

@JakobJingleheimer JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

How-so does the migration unintentionally affect other files?

Comment thread recipes/fs-access-mode-constants/src/workflow.ts Outdated
Comment thread recipes/fs-access-mode-constants/src/workflow.ts Outdated
Comment thread recipes/fs-access-mode-constants/src/workflow.ts Outdated
Comment thread recipes/fs-access-mode-constants/src/workflow.ts Outdated
Comment thread recipes/fs-access-mode-constants/src/workflow.ts Outdated
Comment thread recipes/fs-access-mode-constants/src/workflow.ts Outdated
Comment thread recipes/fs-access-mode-constants/src/workflow.ts Outdated
Comment thread recipes/fs-access-mode-constants/src/workflow.ts

@JakobJingleheimer JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good 🙂

@JakobJingleheimer JakobJingleheimer added awaiting author Reviewer has requested something from the author and removed awaiting reviewer Author has responded and needs action from the reviewer labels Mar 24, 2026
@AugustinMauroy

Copy link
Copy Markdown
Member Author

@JakobJingleheimer added

@AugustinMauroy AugustinMauroy added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Apr 9, 2026
Comment thread recipes/fs-access-mode-constants/src/workflow.ts Outdated
@JakobJingleheimer JakobJingleheimer added g2g No outstanding concerns, discussions, or issues. and removed awaiting reviewer Author has responded and needs action from the reviewer labels Apr 18, 2026
@JakobJingleheimer JakobJingleheimer added the bug PR fixing a bug label Apr 26, 2026
@AugustinMauroy AugustinMauroy changed the title fix(fs-access-mode-constants): don't modify other thing fix(fs-access-mode-constants): don't modify other thing Apr 29, 2026
@AugustinMauroy AugustinMauroy merged commit d1ad539 into main Jul 2, 2026
14 checks passed
@AugustinMauroy AugustinMauroy deleted the fix-fs-balbala branch July 2, 2026 13:11
ShamyaHaria pushed a commit to ShamyaHaria/userland-migrations that referenced this pull request Jul 6, 2026
Co-authored-by: Bruno Rodrigues <swe@brunocroh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug PR fixing a bug g2g No outstanding concerns, discussions, or issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants