Skip to content

Print caveats on npm-postinstall #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2018
Merged

Print caveats on npm-postinstall #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37bc0c9
Adds postinstall script for displaying NODE_BUILD_DEFINITIONS caveats
jasonkarns Dec 8, 2018
b1037c7
Include script in tarball and run after install
jasonkarns Dec 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@
"url": "https://github.com/nodenv/node-build-prerelease/issues"
},
"files": [
"script",
"share"
],
"directories": {
"test": "./test"
"test": "test"
},
"scripts": {
"postinstall": "script/postinstall",
"posttest": "npm run lint",
"lint": "git ls-files bin script **/*.*sh | xargs shellcheck",
"verify-definitions": "scripty",
Expand Down
24 changes: 24 additions & 0 deletions script/postinstall
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#!/usr/bin/env bash

set -euo pipefail
IFS=$'\n\t'

installed_by_name() {
local pattern='"remain":\["'${npm_package_name-}

[[ ${npm_config_argv-} =~ $pattern ]]
}

if [ -n "${npm_config_argv-}" ] && ! installed_by_name; then
exit
fi

cat <<-MSG
====================
${npm_package_name-} caveats:

For \`node-build\`/\`nodenv install\` to pick up definitions provided by this plugin,
ensure '$PWD/share/node-build' exists in NODE_BUILD_DEFINITIONS.
export NODE_BUILD_DEFINITIONS="$PWD/share/node-build"
====================
MSG