Skip to content

Adding typescript typings plugin#51

Merged
aalykiot merged 1 commit intomainfrom
ts-typings
Aug 4, 2021
Merged

Adding typescript typings plugin#51
aalykiot merged 1 commit intomainfrom
ts-typings

Conversation

@aalykiot
Copy link
Copy Markdown
Member

@aalykiot aalykiot commented Aug 3, 2021

References #48

@aalykiot
Copy link
Copy Markdown
Member Author

aalykiot commented Aug 4, 2021

@richardlau are you okay with me merging this one ??

@richardlau
Copy link
Copy Markdown
Member

@richardlau are you okay with me merging this one ??

LGTM. Go for it 🙂.

@aalykiot aalykiot merged commit 4da2c41 into main Aug 4, 2021
@aalykiot aalykiot deleted the ts-typings branch August 4, 2021 16:25
aalykiot added a commit that referenced this pull request Aug 5, 2021
* TypeError when GitHub URL is not defined #52

* TypeError when GitHub URL is not defined #52

* feat: adding typescript typings plugin (#51)

* chore: use coveralls action (#55)

Use the Coveralls GitHub action instead of the module to allow
coverage runs on pull requests from forks.

Fixes: #54

* TypeError when GitHub URL is not defined #52

* Rebase with main #52

* TypeError when GitHub URL is not defined #52

* TypeError when GitHub URL is not defined #52

Co-authored-by: Zubin Bhasin <zubin.bhasin@freecharge.com>
Co-authored-by: Alex Alikiotis <alexalikiotis5@gmail.com>
Co-authored-by: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants