Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Conversation

@theodorosploumis
Copy link

I think it would be nice to have these files on the repo too! Thanks for the example.

@retrohacker
Copy link
Contributor

Hey @theodorosploumis!

These files look great, thank you for opening this PR!

Part of me says that a big portion of the tutorial is actually creating those files and getting familiar with the syntax...

The other part says that people need a reference solution for when their file isn't working and they don't know why...

Perhaps we can get the best of both worlds? What are your thoughts on creating a directory called solution and moving these files there?

@theodorosploumis
Copy link
Author

Or maybe create a separated branch with the solutions included.

@retrohacker
Copy link
Contributor

Hmm... Would a branch be as easy to find as a folder?

@retrohacker
Copy link
Contributor

The branch would probably be cleaner but might be harder to find.

If we included a solutions directory, we would probably need to include a .dockerignore file as well.

@theodorosploumis
Copy link
Author

Most of the examples of that type (git repos) have separated branches and a declaration on the readme about using other branches. Users are to lean docker they know how to use Github. Also, if we use another folder we need to copy again all the files inside the folder.

@theodorosploumis
Copy link
Author

Also, if there is no complete setup users will not be able to propose changes, improvements (like mine) and reuse/extend the code to their needs.

@retrohacker
Copy link
Contributor

This landed in the solutions branch of this repo. Instructions were added to the readme directing users to that branch.

Thanks for the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants