lib,src,test: add http protocol version to spans#276
Closed
santigimeno wants to merge 3 commits intonode-v22.x-nsolid-v5.xfrom
Closed
lib,src,test: add http protocol version to spans#276santigimeno wants to merge 3 commits intonode-v22.x-nsolid-v5.xfrom
santigimeno wants to merge 3 commits intonode-v22.x-nsolid-v5.xfrom
Conversation
No need to subscribe to the `TracingChannels` directly, but calling `bindStore()` it's enough as it sets the channel as `ActiveChannel`.
Don't use the current active span but store the span in the `request` instance and retrieve it from there when needed.
santigimeno
added a commit
that referenced
this pull request
Mar 10, 2025
No need to subscribe to the `TracingChannels` directly, but calling `bindStore()` it's enough as it sets the channel as `ActiveChannel`. PR-URL: #276 Fixes: nodesource/nsolid-roadmap#26 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Mar 10, 2025
Don't use the current active span but store the span in the `request` instance and retrieve it from there when needed. PR-URL: #276 Fixes: nodesource/nsolid-roadmap#26 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Mar 10, 2025
Fixes: nodesource/nsolid-roadmap#26 PR-URL: #276 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Member
Author
|
Landed in d41e139...e83552a |
santigimeno
added a commit
that referenced
this pull request
May 1, 2025
No need to subscribe to the `TracingChannels` directly, but calling `bindStore()` it's enough as it sets the channel as `ActiveChannel`. PR-URL: #276 Fixes: nodesource/nsolid-roadmap#26 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
May 1, 2025
Don't use the current active span but store the span in the `request` instance and retrieve it from there when needed. PR-URL: #276 Fixes: nodesource/nsolid-roadmap#26 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
May 1, 2025
Fixes: nodesource/nsolid-roadmap#26 PR-URL: #276 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
May 2, 2025
No need to subscribe to the `TracingChannels` directly, but calling `bindStore()` it's enough as it sets the channel as `ActiveChannel`. PR-URL: #276 Fixes: nodesource/nsolid-roadmap#26 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
May 2, 2025
Fixes: nodesource/nsolid-roadmap#26 PR-URL: #276 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
May 7, 2025
No need to subscribe to the `TracingChannels` directly, but calling `bindStore()` it's enough as it sets the channel as `ActiveChannel`. PR-URL: #276 Fixes: nodesource/nsolid-roadmap#26 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
May 7, 2025
Fixes: nodesource/nsolid-roadmap#26 PR-URL: #276 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/nodesource/nsolid-roadmap/issues/26
It also comes with a couple of commits fixing/improving tracing issues: