agents: fix possible grpc mutex race condition#277
Closed
santigimeno wants to merge 2 commits intonode-v22.x-nsolid-v5.xfrom
Closed
agents: fix possible grpc mutex race condition#277santigimeno wants to merge 2 commits intonode-v22.x-nsolid-v5.xfrom
santigimeno wants to merge 2 commits intonode-v22.x-nsolid-v5.xfrom
Conversation
As reported by abseil-cpp. By the looks of it, it's fixed if we make sure `CommandStream` instnace is created before the `OtlpGrpcClient` instance. Fixes: nodesource/nsolid-roadmap#28
santigimeno
added a commit
that referenced
this pull request
Mar 20, 2025
Fixes: nodesource/nsolid-roadmap#28 PR-URL: #277 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Mar 20, 2025
As reported by abseil-cpp. By the looks of it, it's fixed if we make sure `CommandStream` instnace is created before the `OtlpGrpcClient` instance. Fixes: nodesource/nsolid-roadmap#28 PR-URL: #277 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Member
Author
|
Landed in e83552a...4dbec36 |
santigimeno
added a commit
that referenced
this pull request
May 1, 2025
As reported by abseil-cpp. By the looks of it, it's fixed if we make sure `CommandStream` instnace is created before the `OtlpGrpcClient` instance. Fixes: nodesource/nsolid-roadmap#28 PR-URL: #277 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
May 2, 2025
As reported by abseil-cpp. By the looks of it, it's fixed if we make sure `CommandStream` instnace is created before the `OtlpGrpcClient` instance. Fixes: nodesource/nsolid-roadmap#28 PR-URL: #277 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
May 7, 2025
As reported by abseil-cpp. By the looks of it, it's fixed if we make sure `CommandStream` instnace is created before the `OtlpGrpcClient` instance. Fixes: nodesource/nsolid-roadmap#28 PR-URL: #277 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by abseil-cpp. By the looks of it, it's fixed if we make
sure
CommandStreaminstnace is created before theOtlpGrpcClientinstance.
Also:
Fixes: https://github.com/nodesource/nsolid-roadmap/issues/28