test: fix flaky test-otlp-grpc-metrics#281
Closed
santigimeno wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
Closed
test: fix flaky test-otlp-grpc-metrics#281santigimeno wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
santigimeno wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
Conversation
santigimeno
force-pushed
the
santi/fix_flaky_otlp_grpc_metrics_test
branch
from
b8c562a to
c19d441
Compare
juanarbol
approved these changes
Apr 8, 2025
Contributor
juanarbol
left a comment
juanarbol
left a comment
There was a problem hiding this comment.
LGTM, just a question left
After having enabled `ENABLE_ASYNC_EXPORT` in `opentelemetry-cpp`.
santigimeno
force-pushed
the
santi/fix_flaky_otlp_grpc_metrics_test
branch
from
c19d441 to
f18e72e
Compare
santigimeno
added a commit
that referenced
this pull request
Apr 10, 2025
After having enabled `ENABLE_ASYNC_EXPORT` in `opentelemetry-cpp`. PR-URL: #281 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Member
Author
|
Landed in a8135cd |
santigimeno
added a commit
that referenced
this pull request
May 1, 2025
After having enabled `ENABLE_ASYNC_EXPORT` in `opentelemetry-cpp`. PR-URL: #281 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
May 2, 2025
After having enabled `ENABLE_ASYNC_EXPORT` in `opentelemetry-cpp`. PR-URL: #281 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
added a commit
that referenced
this pull request
May 7, 2025
After having enabled `ENABLE_ASYNC_EXPORT` in `opentelemetry-cpp`. PR-URL: #281 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After having enabled
ENABLE_ASYNC_EXPORTinopentelemetry-cpp.