src: fix GetSourceCode for ESM file url#296
src: fix GetSourceCode for ESM file url#296santigimeno wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
Conversation
As the loaded modules are indexed by url, we need to convert those into actual paths in order to be able to read those files.
WalkthroughThe changes update both source and test code to handle file path and file URL conversions more robustly by leveraging Node.js utilities and URL parsing libraries. In the main source, the conversion from file URLs to filesystem paths is now performed using Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used🪛 Cppcheck (2.10-2)src/nsolid/nsolid_api.cc[error] 17-17: There is an unknown macro here somewhere. Configuration is required. If SERIALIZABLE_OBJECT_METHODS is a macro then please configure it. (unknownMacro) 🔇 Additional comments (9)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
As the loaded modules are indexed by url, we need to convert those into actual paths in order to be able to read those files. PR-URL: #296 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
|
Landed in 08f118f |
As the loaded modules are indexed by url, we need to convert those into actual paths in order to be able to read those files. PR-URL: #296 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
As the loaded modules are indexed by url, we need to convert those into actual paths in order to be able to read those files. PR-URL: #296 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2 participants
As the loaded modules are indexed by url, we need to convert those into actual paths in order to be able to read those files.
Summary by CodeRabbit
Bug Fixes
Tests