Skip to content

agents: support contCpuProfile command in the GRPC interface#297

Closed
juanarbol wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
juan/cprofiling
Closed

agents: support contCpuProfile command in the GRPC interface#297
juanarbol wants to merge 1 commit intonode-v22.x-nsolid-v5.xfrom
juan/cprofiling

Conversation

@juanarbol
Copy link
Copy Markdown
Contributor

@juanarbol juanarbol commented Apr 29, 2025 •
edited by coderabbitai Bot
Loading

Fixes: https://github.com/nodesource/nsolid-roadmap/issues/30

Summary by CodeRabbit

  • New Features
    • Added support for configuring continuous CPU profiling during agent reconfiguration. Users can now enable or disable this option as part of the reconfiguration process.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2025 •
edited
Loading

"""

Walkthrough

A new optional boolean field, contCpuProfile, was added to the ReconfigureBody message in the gRPC agent's protobuf schema. The generated protobuf C++ code and header were updated to support this field, including presence tracking and accessor methods. The gRPC agent's implementation was modified to read and write the contCpuProfile field during reconfiguration, ensuring the setting is properly handled in both JSON and protobuf representations. No other logic or control flow was changed.

Changes

File(s) Change Summary
agents/grpc/proto/reconfigure.proto Added optional boolean field contCpuProfile (field 12) to ReconfigureBody message.
agents/grpc/src/proto/reconfigure.pb.cc,
agents/grpc/src/proto/reconfigure.pb.h		 Protobuf-generated code updated: new member, accessor methods, presence tracking, parsing, serialization, etc.
agents/grpc/src/grpc_agent.cc Logic updated to read/write contCpuProfile in config reconfiguration routines.
test/agents/test-grpc-reconfigure.mjs Added contCpuProfile to test configurations to verify proper update handling in reconfigure tests.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Expose/trigger c-profiling via gRPC protocol (#30) ✅

Poem

A bunny hopped through fields of code,
With protobufs and flags in its load.
"contCpuProfile" now hops along,
In configs where it does belong.
gRPC now knows the way,
To profile CPUs night and day!
🐇✨
"""

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5cc5dda and da82ccf.

📒 Files selected for processing (5)
  • agents/grpc/proto/reconfigure.proto (1 hunks)
  • agents/grpc/src/grpc_agent.cc (2 hunks)
  • agents/grpc/src/proto/reconfigure.pb.cc (16 hunks)
  • agents/grpc/src/proto/reconfigure.pb.h (4 hunks)
  • test/agents/test-grpc-reconfigure.mjs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • agents/grpc/proto/reconfigure.proto
  • test/agents/test-grpc-reconfigure.mjs
  • agents/grpc/src/grpc_agent.cc
  • agents/grpc/src/proto/reconfigure.pb.h
  • agents/grpc/src/proto/reconfigure.pb.cc
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: coverage-linux
  • GitHub Check: build-tarball
  • GitHub Check: test-linux (ubuntu-24.04-arm)
  • GitHub Check: coverage-linux-without-intl
  • GitHub Check: test-linux (ubuntu-24.04)
  • GitHub Check: lint-js-and-md
  • GitHub Check: test-macOS
  • GitHub Check: coverage-windows
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

santigimeno
santigimeno approved these changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@santigimeno santigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but before landing it needs updating test-grpc-reconfigure.mjs to check for this field

@juanarbol @santigimeno
agents: support contCpuProfile command in the GRPC interface
da82ccf 
Fixes: nodesource/nsolid-roadmap#30
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
@santigimeno
Copy link
Copy Markdown
Member

santigimeno commented May 13, 2025

Landed in 3cc36a4

santigimeno pushed a commit that referenced this pull request May 13, 2025
@juanarbol @santigimeno
agents: support contCpuProfile command in the GRPC interface
3cc36a4 
Fixes: nodesource/nsolid-roadmap#30
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #297
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@santigimeno santigimeno deleted the juan/cprofiling branch May 13, 2025 07:52
santigimeno pushed a commit that referenced this pull request May 15, 2025
@juanarbol @santigimeno
agents: support contCpuProfile command in the GRPC interface
6d8741c 
Fixes: nodesource/nsolid-roadmap#30
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #297
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
santigimeno pushed a commit that referenced this pull request Aug 25, 2025
@juanarbol @santigimeno
agents: support contCpuProfile command in the GRPC interface
30fd0c8 
Fixes: nodesource/nsolid-roadmap#30
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #297
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
santigimeno pushed a commit that referenced this pull request Aug 26, 2025
@juanarbol @santigimeno
agents: support contCpuProfile command in the GRPC interface
daaac13 
Fixes: nodesource/nsolid-roadmap#30
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #297
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #359
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@santigimeno santigimeno santigimeno approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juanarbol @santigimeno