Skip to content

feat(vault-namespace): set 'X-Vault-Namespace' when a client has it#137

Merged
kr1sp1n merged 2 commits intonodevault:masterfrom
kakoc:feat/vault-namespace
Jun 11, 2020
Merged

feat(vault-namespace): set 'X-Vault-Namespace' when a client has it#137
kr1sp1n merged 2 commits intonodevault:masterfrom
kakoc:feat/vault-namespace

Conversation

@kakoc
Copy link
Copy Markdown
Contributor

@kakoc kakoc commented Aug 22, 2019

related issue #123

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2019

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #137   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          143       146    +3     
  Branches        35        37    +2     
=========================================
+ Hits           143       146    +3     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6a6fa...430fe2c. Read the comment docs.

@kakoc kakoc force-pushed the feat/vault-namespace branch from 56a0345 to a079cf2 Compare August 28, 2019 12:36
@kakoc kakoc force-pushed the feat/vault-namespace branch from a079cf2 to 0ccadad Compare September 3, 2019 17:18
@Pluies
Copy link
Copy Markdown

Pluies commented Nov 1, 2019

Hi @kr1sp1n 👋
Would it be possible to look into merging this feature? I understand that it's a very specific Entreprise-only (AFAIK) Vault feature, but having support would be hugely useful for us as well.
Thank you!

  • Florent

@Pluies
Copy link
Copy Markdown

Pluies commented Nov 5, 2019

FWIW I've forked node-vault, applied @kakoc 's patch and published the package under a personal NPM repo (@florentdelannoyynap/node-vault) and I can report everything is working beautifully!

@ChamNouki
Copy link
Copy Markdown

If i well understand how this package work, following code should do the same thing than this PR :

const vaultOptions: VaultOptions = {
  requestOptions: {
    headers: {
      'X-Vault-Namespace': process.env.VAULT_NAMESPACE
    }
  }
};

const vault = Vault(vaultOptions);

However I still have an error but this time it's a 404.

@kr1sp1n kr1sp1n merged commit ee3d872 into nodevault:master Jun 11, 2020
@kr1sp1n
Copy link
Copy Markdown
Collaborator

kr1sp1n commented Jun 11, 2020

@kakoc Thanks for your PR 👍
@Pluies Released as v0.9.18 🎉
Closes #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants