feat(vault-namespace): set 'X-Vault-Namespace' when a client has it#137
feat(vault-namespace): set 'X-Vault-Namespace' when a client has it#137kr1sp1n merged 2 commits intonodevault:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 143 146 +3
Branches 35 37 +2
=========================================
+ Hits 143 146 +3
Continue to review full report at Codecov.
|
56a0345 to
a079cf2
Compare
a079cf2 to
0ccadad
Compare
|
Hi @kr1sp1n 👋
|
|
FWIW I've forked node-vault, applied @kakoc 's patch and published the package under a personal NPM repo (@florentdelannoyynap/node-vault) and I can report everything is working beautifully! |
|
If i well understand how this package work, following code should do the same thing than this PR : const vaultOptions: VaultOptions = {
requestOptions: {
headers: {
'X-Vault-Namespace': process.env.VAULT_NAMESPACE
}
}
};
const vault = Vault(vaultOptions);However I still have an error but this time it's a 404. |
related issue #123