Sync index.d.ts type definitions with commands.js#283
Merged
aviadhahami merged 3 commits intomasterfrom Mar 12, 2026
Merged
Conversation
Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com>
- Remove duplicate ldapLogin declaration (fixes #203) - Remove phantom generateRootStatus (not in commands.js) - Add missing unwrap method - Add missing addKubernetesRole, getKubernetesRole, deleteKubernetesRole methods Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with secret retrieval in node-vault
Sync index.d.ts type definitions with commands.js
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
index.d.tswas out of sync withsrc/commands.js— missing methods, a phantom method, and a duplicate declaration.Changes
ldapLogin— PR chore: add missing ldapLogin method in index.d.ts #205 added it without noticing it already existed lower in the filegenerateRootStatus— declared in types but never existed incommands.jsunwrap,addKubernetesRole,getKubernetesRole,deleteKubernetesRoleAll methods in
commands.jsnow have corresponding type declarations, and vice versa.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.