Restore backward-compatible requestOptions for axios migration#286
Merged
aviadhahami merged 7 commits intomasterfrom Mar 12, 2026
Merged
Restore backward-compatible requestOptions for axios migration#286aviadhahami merged 7 commits intomasterfrom
aviadhahami merged 7 commits intomasterfrom
Conversation
Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com>
Map postman-request-style TLS options (ca, cert, key, passphrase, pfx, agentOptions, strictSSL) from requestOptions to an httpsAgent for axios. Fixes #285 Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com>
…n override Address code review feedback: config.requestOptions TLS settings are now baked into the default httpsAgent at initialization time. Per-request agents are only created when per-call TLS options differ from the config defaults. Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com>
… docs - Forward timeout, httpsAgent, httpAgent from requestOptions to axios per-request options (the README bastion host example now works) - Update README: replace stale postman-request reference with axios - Fix example/auth.js: remove silently-ignored followAllRedirects - Add 3 new tests for timeout, httpsAgent, httpAgent forwarding Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com>
Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [NODE-285] Fix issue with retrieving secrets
Restore backward-compatible requestOptions for axios migration
Mar 12, 2026
aviadhahami
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #278 replaced
postman-requestwithaxiosbut silently dropped support for TLS options (ca,cert,key,passphrase,agentOptions,strictSSL) passed viarequestOptions. The README also documentedhttpsAgent/httpAgent/timeoutforwarding that never actually worked.Changes
src/index.js: Mappostman-request-style TLS options tohttps.Agentin the axios request wrapper. Config-level TLS options are baked into the default agent at init time; per-request agents are only created when per-call options differ (reference comparison). Also forwardtimeout,httpsAgent,httpAgentto per-request axios options.index.d.ts: AddTlsOptionsinterface (ca,cert,key,passphrase,pfx,strictSSL,agentOptions,timeout) merged withAxiosRequestConfigforrequestOptionstype.README.md: Replace stalepostman-requestreference with accurate description of supported options.example/auth.js: RemovefollowAllRedirects(silently ignored since axios migration).test/unit.js: 10 new tests covering TLS forwarding, agent caching, and option passthrough.Usage
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.