Coveralls in search page #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ckiss could you please review? |
client/components/module-source.js
Outdated
| 'use strict' | ||
|
|
||
| import React from 'react' | ||
| import ClassName from 'classnames' |
There was a problem hiding this comment.
I use to name this classNames :) I don't see the need to use pascal case
|
@mihaidma few very small things, otherwise LGTM. feel free to merge if you don't agree with my remarks 👍 |
mihaidma
force-pushed
the
coverallssearch
branch
from
5346a8e to
1b143f3
Compare
mihaidma
force-pushed
the
coverallssearch
branch
from
1b143f3 to
a27dc39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coveralls integrated in search page