Skip to content

Added _trim_config_dicts to ProxyPc3 #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcin-usielski merged 2 commits into from
Dec 16, 2024
Merged

Added _trim_config_dicts to ProxyPc3 #558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7d5654
Added _trim_config_dicts to ProxyPc3
marcin-usielski Dec 16, 2024
dcd2f43
style
marcin-usielski Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions moler/device/proxy_pc3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,16 +76,8 @@ def _prepare_dicts_for_sm(self, sm_params):

default_sm_configurations = self._get_default_sm_configuration()

if not self._use_proxy_pc:
(connection_hops, transitions) = remove_state_from_sm(
source_sm=default_sm_configurations[ProxyPc3.connection_hops],
source_transitions=transitions,
state_to_remove=ProxyPc3.proxy_pc,
)
state_hops = remove_state_hops_from_sm(
source_hops=state_hops, state_to_remove=ProxyPc3.proxy_pc
)
default_sm_configurations[ProxyPc3.connection_hops] = connection_hops
(default_sm_configurations, transitions, state_hops) = self._trim_config_dicts(
default_sm_configurations, transitions, state_hops)

self._stored_transitions = transitions
self._update_dict(self._state_hops, state_hops)
Expand All @@ -97,6 +89,26 @@ def _prepare_dicts_for_sm(self, sm_params):
self._validate_device_configuration()
self._prepare_state_prompts()

def _trim_config_dicts(self, default_sm_configurations, transitions, state_hops):
"""
Remove required state (mainly PROXY_PC) from State Machine configuration if necessary.
:param default_sm_configurations: default State Machine configuration.
:param transitions: transitions between states.
:param state_hops: non direct transitions between states.
:return: trimmed State Machine configuration (tuple with new values of passed arguments).
"""
if not self._use_proxy_pc:
(connection_hops, transitions) = remove_state_from_sm(
source_sm=default_sm_configurations[ProxyPc3.connection_hops],
source_transitions=transitions,
state_to_remove=ProxyPc3.proxy_pc,
)
state_hops = remove_state_hops_from_sm(
source_hops=state_hops, state_to_remove=ProxyPc3.proxy_pc
)
default_sm_configurations[ProxyPc3.connection_hops] = connection_hops
return (default_sm_configurations, transitions, state_hops)

def _overwrite_prompts(self) -> None:
"""
Method to overwrite prompts in commands.
Expand Down
Loading