Skip to content

Load config from dict#60

Merged
emcek merged 6 commits intomasterfrom
load_config_from_dict
Oct 17, 2018
Merged

Load config from dict#60
emcek merged 6 commits intomasterfrom
load_config_from_dict

Conversation

@greg-latuszek
Copy link
Copy Markdown
Collaborator

No description provided.

'host': 'test.rebex.net',
'login': 'demo',
'password': 'password',
'set_timeout': False}}}}}}},
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_timeout = None. The same effect but set_timeout is command string to set timeout.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Marcin

Copy link
Copy Markdown
Collaborator

@emcek emcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 17, 2018

Pull Request Test Coverage Report for Build 941

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 90.696%

Totals Coverage Status
Change from base Build 931: 0.01%
Covered Lines: 6219
Relevant Lines: 6857

💛 - Coveralls

@emcek emcek merged commit a83f3c3 into master Oct 17, 2018
@emcek emcek deleted the load_config_from_dict branch October 17, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants