fix: use POST instead of PATCH for ADO work item creation#391
Merged
Conversation
Azure DevOps API requires POST (not PATCH) for creating work items. Also fixed category grouping to always register group commands. Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f526f3292
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Reverted incorrect unconditional _mount_installed_category_groups call - Updated test_create_issue mocks to use requests.post instead of requests.patch Made-with: Cursor
The test_bootstrap_with_category_grouping_disabled_registers_flat_commands test expects bundles like specfact-codebase to be installed, but in CI they may not be. Added pytest.skip() when 'code' command is not available. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed Azure DevOps work item creation API method and category grouping registration.
Fixes: ADO work item creation failing with 400 Bad Request due to incorrect HTTP method.
Type of Change
Contract-First Testing Evidence
Test Execution
hatch run contract-test-contracts✅hatch run smart-test-unit✅Test Quality
How Has This Been Tested?
Automated Testing
hatch run format)hatch run type-check)Test Environment
Changes Made
src/specfact_cli/adapters/ado.py:
requests.patchtorequests.postincreate_work_item_from_proposal()(line 1762)requests.patchtorequests.postincreate_issue()(line 3459)src/specfact_cli/registry/module_packages.py:
category_grouping_enabled_mount_installed_category_groups()is now always calledVersion bump to 0.40.4:
Checklist
Quality Gates Status
hatch run type-check)hatch run format)hatch run contract-test-contracts)hatch run smart-test-full)