Skip to content

Suggestion: Have implementation of BaseOfficeFile's functions support any parameters #87

@gdesmar

Description

@gdesmar

The BaseOfficeFile defines three functions that can be implemented. If we look at load_key(), doc97, ppt97 and xls97 take the same arguments and behave similarly. Looking at ooxml, it takes more arguments and does not validate the password (if provided) by default. As I want to validate the password, I cannot call the function load_key() in an agnostic way.
Do you think it would be valuable to catch extra parameters in all implementations of load_key() and decrypt() with *args + **kwargs to make it more uniform?
I can see the downside of a user passing parameters that are ignored, and not understanding why it does nothing, so I do not have strong feelings on this suggestion.
Thank you for your time! 🙂

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions