Add repository verification check for GitHub webhook processing#151
Add repository verification check for GitHub webhook processing#151
Conversation
- Migration: adds is_verified boolean (default false) to repositories_secure - Types: updates supabase.ts with is_verified in Row/Insert/Update for repositories_secure - Webhook route: always stores event logs, but only triggers processGithubEvents when the repo is verified https://claude.ai/code/session_01L3ggVkMPd8P1Dhm4nATTwR
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Not sensitive data — fits alongside is_private and other operational flags. Simplifies the webhook query (no join needed). https://claude.ai/code/session_01L3ggVkMPd8P1Dhm4nATTwR
|
@claude review |
|
Claude finished @lws803's task in 1m 18s —— View job Code Review
Overall, this is a clean and straightforward implementation. A few issues worth addressing: Bug: PR Description Contradicts Actual BehaviorThe PR description states:
But the code at Inconsistency: Star Events Bypass VerificationStar events (subscribe/unsubscribe) at If unverified repos should be fully read-only, the Migration File Naming MismatchThe migration file is named Note: Migration Backfills All Existing Repos as Verified
Positive Notes
|
yup this was intentional |
|
@claude review again Note that this was intentional Note: Migration Backfills All Existing Repos as Verified |
|
Claude finished @lws803's task in 56s —— View job Code Review (Re-review)
Acknowledged that the migration backfill ( Open: PR Description Is InaccurateThe PR description states:
The code at Open: Star Events Bypass Verification (Intentional?)Star events at If unverified repos should be completely passive, consider moving the Open: Migration File Name Mismatch
Confirmed
|
Moved is_verified guard before star event handling. Only metadata sync (repository edited) bypasses the check. https://claude.ai/code/session_01L3ggVkMPd8P1Dhm4nATTwR
|
@claude review again |
|
Claude finished @lws803's task in 48s —— View job Code Review (Re-review)
Good news: since the last review, Two items remain: Open: PR Description Is InaccurateThe description still states:
In the current code, Minor: Migration File Name Is Generic
Confirmed / Resolved
|
When repos are installed (via installation or installation_repositories webhook), check if the org already has any verified repos. If so, mark the new repos as verified too; otherwise default to false. https://claude.ai/code/session_01L3ggVkMPd8P1Dhm4nATTwR
|
@claude review |
|
Claude finished @lws803's task in 1m 3s —— View job Code Review (Re-review)
The implementation looks clean overall. Here's the current state: Open: PR Description InaccuracyThe description still states:
Current code ( New: Auto-Verification Logic in
|
…add-repo-verified-column-B4jzN
Description
This PR adds a verification mechanism to control which repositories can trigger GitHub event processing. The changes include:
is_verifiedboolean field to therepositories_securetable to track repository verification statusThis allows for better control over which repositories can trigger automated processing while maintaining a complete audit trail of all webhook events.
How to test
is_verifiedcolumn torepositories_secureis_verified = falseis_verified = true) trigger processing as expectedhttps://claude.ai/code/session_01L3ggVkMPd8P1Dhm4nATTwR