[draft] remove requirement for AtlasDataset unique-id-field #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcembalest
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| logger.info(f"Loading existing dataset `{identifier}`.") | ||
| dataset_id = dataset["id"] | ||
|
|
||
| if dataset_id is None: # if there is no existing project, make a new one. |
Contributor
There was a problem hiding this comment.
Removing the check for unique_id_field here allows creating a dataset without a unique ID field. However, later parts of the code (e.g. in _validate_and_correct_arrow_upload) assume that project.id_field exists and is used to validate that data contains that column. This could lead to errors when unique_id_field is None.
Contributor
Author
|
gonna reopen anew |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Remove requirement for
unique_id_fieldinAtlasDatasetcreation, allowing it to be optional.unique_id_fieldinAtlasDataset.__init__()andAtlasDataset._create_project().unique_id_fieldisNonein both methods.unique_id_fieldparameter toOptional[str]inAtlasDataset._create_project().unique_id_fieldchecks indataset.py.This description was created by
for 1f7da15. It will automatically update as commits are pushed.