Update JavaScript about SHUKUDAI_NOTATION to support importmap#144
Merged
SenoOh merged 1 commit intonomlab:mainfrom Jul 18, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
やったこと
背景
変更点
app/javascript/application.jsを更新したimport "documents"を追加したapp/javascript配下のdocuments.jsをimport する設定を書き込んだconfig/importmap.rbを更新したpin "documents", to: "documents.js"を追加したimport "documents"のdocumentsとdocuments.jsを対応させたapp/views/documents/show.html.erbを更新したapp/views/layout/application.rbに<%= javascript_importmap_tags %>として,importmap を用いるすべての JavaScript を読み込む記述がある<%= javascript_include_tag 'documents' %>を削除したapp/javascript/documents.jsを更新したgetElementByIdの記法に変更した