Skip to content

Move "unable to activate" modal to "loading server info screen" #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2016
Merged

Move "unable to activate" modal to "loading server info screen" #2018

merged 1 commit into from
Sep 22, 2016

Conversation

@nb-ohad
Copy link
Contributor

@nb-ohad nb-ohad commented Sep 22, 2016

  • Model:
  • Actions:
    • Reset serverInfo on every loadServerInfo invocation.
  • Components:
    • Change: create-system-form (remove 'unable-to-activate-modal')
    • Change: loading-server-information-from (add 'unable-to-activate-modal')
    • Change: login-layout (change from selection logic)

@nb-ohad
Copy link
Contributor Author

nb-ohad commented Sep 22, 2016

@jeniawhite plesae review

@nb-ohad nb-ohad merged commit f54bd64 into master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeniawhite jeniawhite jeniawhite approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nb-ohad @jeniawhite