Skip to content

Conversation

@jeniawhite
Copy link
Contributor

For FE PRs use the template

Purpose

  • Fixes nodes_monitor builders that collide and work on same chunks

Checklist

  • Code:
  • User Experience: Taken a moment to think the effects on our user
  • Failure handling and Comments on non trivial sections:
  • Cross Platform: Supporting Win 7/8/10 Server 12, Linux, Mac
  • Testing:
  • Unit/System Tests: Added tests ... / Already covered by existing tests ...
  • Tested with: npm test
  • Supportability:
  • Diagnostics info, Phone Home info, ActivityLog events, External Syslog:
  • Upgrade:
  • Mongo Schema Upgrade:
  • Agents changes, Server Platform changes and New packages added to package.json:

Technical Debt Created

Fixed Issues References

@guymguym
Copy link
Member

@jeniawhite Thought about waited_to_run again it's not the right solution (my bad).
The reason it is wrong to consider loading the chunks only if the lock waited is that there could be many cases where the race happens even without the lock wait, just because of the asynchronous nature of the database connection. Lets discuss.

@guymguym guymguym merged commit 6ec3841 into master Jan 17, 2017
@jeniawhite jeniawhite deleted the evgb-RebuildAllocationBug branch February 1, 2017 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants