-
Notifications
You must be signed in to change notification settings - Fork 91
reduced log chattiness - changed level of log0 messages #6967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
liranmauda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
In General this is a good practice, even when the logs are only printed in a catch of an error, printing them in dbg0 will cause it to be ignored in the case where we set the debug level to warn in the config map
noobaa-core/src/util/debug_config.js
Lines 27 to 31 in 069e2f6
| const warn = { | |
| level: -1, | |
| core: ['core'], | |
| endpoint: ['core'], | |
| }; |
|
@dannyzaken @liranmauda |
@romayalon what is the reason to keep it in log0? |
|
@guymguym can you please share your logging methodology? |
8f9adcc to
7aab766
Compare
Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
Signed-off-by: Danny Zaken dannyzaken@gmail.com
Explain the changes
dbg.log0levellog1Issues: Fixed #xxx / Gap #xxx
Testing Instructions: