Skip to content

Conversation

@dannyzaken
Copy link
Member

@dannyzaken dannyzaken commented May 26, 2022

Signed-off-by: Danny Zaken dannyzaken@gmail.com

Explain the changes

  1. fixed several error\warn messages that were printed with dbg.log0 level
  2. part of an effort to support reduced log chattiness by reducing log level to warn\err only
  3. for some repeating messages increased the log level to log1

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
In General this is a good practice, even when the logs are only printed in a catch of an error, printing them in dbg0 will cause it to be ignored in the case where we set the debug level to warn in the config map

const warn = {
level: -1,
core: ['core'],
endpoint: ['core'],
};

@romayalon
Copy link
Contributor

romayalon commented May 29, 2022

@dannyzaken @liranmauda
There are several log messages that I specifically was asked to keep as log0 and not as an error/warning.
maybe we should decide on well-defined rules for it.

@dannyzaken
Copy link
Member Author

@dannyzaken @liranmauda There are several log messages that I specifically was asked to keep as log0 and not an error/warning. maybe we should decide on well-defined rules for it.

@romayalon what is the reason to keep it in log0?

@romayalon
Copy link
Contributor

@guymguym can you please share your logging methodology?

@dannyzaken dannyzaken force-pushed the danny-master branch 2 times, most recently from 8f9adcc to 7aab766 Compare May 30, 2022 13:32
@pull-request-size pull-request-size bot added size/S and removed size/M labels May 30, 2022
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 30, 2022
@dannyzaken dannyzaken requested a review from liranmauda May 30, 2022 13:53
@dannyzaken dannyzaken changed the title fixed err\warn messages with log0 level changed the log level of some log0 messages May 30, 2022
@dannyzaken dannyzaken changed the title changed the log level of some log0 messages reduced log chattiness - changed level of log0 messages May 31, 2022
Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants