NSFS | Versioning | ENABLED | Delete object / Delete multiple objects implementation #7154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
force-pushed
the
romy-nsfs-delete-object
branch
from
afe7a54 to
ef4b663
Compare
romayalon
force-pushed
the
romy-nsfs-delete-object
branch
3 times, most recently
from
96d3c39 to
38ad9d1
Compare
romayalon
changed the title
jackyalbo
reviewed
Jan 11, 2023
romayalon
force-pushed
the
romy-nsfs-delete-object
branch
4 times, most recently
from
7949e60 to
30eec56
Compare
jackyalbo
reviewed
Jan 16, 2023
romayalon
force-pushed
the
romy-nsfs-delete-object
branch
3 times, most recently
from
f347162 to
803a851
Compare
jackyalbo
reviewed
Jan 18, 2023
romayalon
force-pushed
the
romy-nsfs-delete-object
branch
2 times, most recently
from
17551f4 to
e0aff80
Compare
jackyalbo
approved these changes
Jan 19, 2023
romayalon
force-pushed
the
romy-nsfs-delete-object
branch
from
0bd102a to
0b0d1ac
Compare
Signed-off-by: Romy <romy2232@gmail.com>
romayalon
force-pushed
the
romy-nsfs-delete-object
branch
from
0b0d1ac to
3b08e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Delete object/ Delete multiple objects support deletion by versioning status.
Implementation of delete object versioning enabled in general -
2.1. If the user passed version id -
2.1.1. The actual version should be deleted
2.1.2. If the deleted version is the latest version we should promote the second latest to be the latest
2.2. else
2.2.1. The latest version (if exists) should move to .versions/
2.2.2. A delete marker should be created in .versions/
Added 3 new helper functions - _delete_object_versioning_enabled(), create_delete_marker(), find_max_version_past().
Added unit tests in test_bucketspace_versioning.js
Issues: Fixed #xxx / Gap #xxx
1.1. Open question regarding the prev_version xattr optimization - on deletion of version id - how we can update the prev version xattr of the following version of the deleted one
1.2. Tests for delete_multiple_objects / test_nsfs_versioning (currently I added the tests in test_bucketspace_versioning)
Testing Instructions: