Changes to all GitHub workflows - timeout, checkout v3, concurrency, general cleanup

.github/workflows/build-arm64-image.yaml

@@ -4,14 +4,18 @@ on: [ push, pull_request ]
 jobs:
   build-arm64-image:
     runs-on: ubuntu-22.04
+    timeout-minutes: 90
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+      cancel-in-progress: true
     env:
       # For multiplatform use list like:
       # "linux/amd64,linux/arm64"
       PLATFORMS: "linux/arm64"
       GIT_COMMIT: ${{ github.sha }}
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           ref: ${{ github.event.inputs.branch }}
 

.github/workflows/build-ppc64le-image.yaml

@@ -4,14 +4,18 @@ on: [ push, pull_request ]
 jobs:
   build-ppc64le-image:
     runs-on: ubuntu-22.04
+    timeout-minutes: 90
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+      cancel-in-progress: true
     env:
       # For multiplatform use list like:
       # "linux/amd64,linux/arm64"
       PLATFORMS: "linux/ppc64le"
       GIT_COMMIT: ${{ github.sha }}
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           ref: ${{ github.event.inputs.branch }}
 

.github/workflows/ceph-s3-tests.yaml

@@ -5,6 +5,9 @@ jobs:
   ceph-s3-tests:
     runs-on: ubuntu-latest
     timeout-minutes: 90
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+      cancel-in-progress: true
     steps:
       - name: Checkout noobaa-core
         uses: actions/checkout@v3

.github/workflows/current-ver-build.yaml

@@ -1,5 +1,4 @@
 name: Current Version Build on Changes
-
 # Run on Backports
 on: 
   push:
@@ -9,6 +8,7 @@ on:
 jobs:
   publish-image:
     runs-on: ubuntu-latest
+    timeout-minutes: 90
     steps:
       - name: Invoke Build on Operator Repo
         uses: benc-uk/workflow-dispatch@v1

.github/workflows/manual-full-build.yaml

@@ -12,9 +12,10 @@ on:
 jobs:
   manual-build-and-publish-image:
     runs-on: ubuntu-latest
+    timeout-minutes: 90
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           ref: ${{ github.event.inputs.branch }}
 

.github/workflows/next-ver-build.yaml

@@ -1,6 +1,4 @@
 name: Next Version Build
-
-# Run the Weekly on Monday 8 AM UTC
 on: 
   schedule:
     - cron: "0 12 * * 1"
@@ -13,6 +11,7 @@ on:
 jobs:
   publish-image:
     runs-on: ubuntu-latest
+    timeout-minutes: 90
     steps:
       - name: Invoke Build on Operator Repo
         uses: benc-uk/workflow-dispatch@v1

.github/workflows/nightly-tests.yaml

@@ -1,20 +1,18 @@
 name: Nightly Tests
-
 on: workflow_dispatch
 
 jobs:
   nightly-tests:
     runs-on: ubuntu-latest
     steps:
       - name: checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Run Nightly Tests
-        id: run-nightly-tests
         run: |
-          make test || exit 1
+          make test
           docker run --rm -e NEWAWSPROJKEY=${{ secrets.NEWAWSPROJKEY }} \
           -e NEWAWSPROJSECRET=${{ secrets.NEWAWSPROJSECRET }} \
           -e NEWAZUREPROJKEY=${{ secrets.NEWAZUREPROJKEY }} \
           -e NEWAZUREPROJSECRET=${{ secrets.NEWAZUREPROJSECRET }} \
-          --name test1 noobaa-tester ./src/test/unit_tests/run_npm_test_on_test_container.sh -s test_s3_ops.js || exit 1
+          --name test1 noobaa-tester ./src/test/unit_tests/run_npm_test_on_test_container.sh -s test_s3_ops.js

.github/workflows/postgres-unit-tests.yaml

@@ -1,18 +1,16 @@
 name: Unit Tests with Postgres
-
-# Run on each new PR and each new push to existing PR
 on: [push, pull_request]
 
 jobs:
   run-unit-tests-postgres:
     runs-on: ubuntu-latest
+    timeout-minutes: 90
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+      cancel-in-progress: true
     steps:
-      - name: Cancel Previous Runs
-        uses: styfle/cancel-workflow-action@0.11.0
-
       - name: Checkout
         uses: actions/checkout@v3
 
       - name: Run Unit Tests with Postgres
-        id: run-test-postgres
-        run: make test-postgres || exit 1
+        run: make test-postgres

.github/workflows/releaser.yaml

@@ -17,6 +17,7 @@ permissions:
 jobs:
   releaser:
     runs-on: ubuntu-latest
+    timeout-minutes: 90
     steps:
       - name: Set branch
         run: echo "BRANCH=${{ github.event.inputs.base_branch }}" >> $GITHUB_ENV

.github/workflows/sanity.yaml

@@ -1,25 +1,24 @@
 name: Build & Sanity
-
-# Run on each new PR and each new push to existing PR
 on: [push, pull_request]
 
 jobs:
   run-sanity-tests:
     runs-on: ubuntu-latest
+    timeout-minutes: 90
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+      cancel-in-progress: true
     steps:
-      - name: checkout
-        uses: actions/checkout@v2
+      - name: Checkout
+        uses: actions/checkout@v3
 
       - name: Deploy minikube
-        id: deploy
         run: sudo bash ./.travis/deploy_minikube.sh
 
       - name: Run make tester
-        id: run-make-tester
-        run: make tester || exit 1
+        run: make tester
 
       - name: Run Build & Sanity Tests
-        id: run-sanity
         run: |
           cd ./src/test/framework/
-          sudo ./run_test_job.sh --name sanity --image noobaa --tester_image noobaa-tester --job_yaml ../../../.travis/travis_test_job.yaml --tests_list ./sanity_tests_list.js --wait || exit 1
+          sudo ./run_test_job.sh --name sanity --image noobaa --tester_image noobaa-tester --job_yaml ../../../.travis/travis_test_job.yaml --tests_list ./sanity_tests_list.js --wait

.github/workflows/unit.yaml

@@ -1,17 +1,18 @@
 name: Unit Tests
-
-# Run on each new PR and each new push to existing PR
 on: [push, pull_request]
 
 jobs:
   run-unit-tests:
     runs-on: ubuntu-latest
+    timeout-minutes: 90
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}
+      cancel-in-progress: true
     steps:
       - name: checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Run Test
-        id: run-test
         run: |
-          make test || exit 1
-          docker run --privileged --rm --name test1 noobaa-tester ./src/test/unit_tests/run_npm_test_on_test_container.sh -s sudo_index.js || exit 1
+          make test
+          docker run --privileged --rm --name test1 noobaa-tester ./src/test/unit_tests/run_npm_test_on_test_container.sh -s sudo_index.js

.github/workflows/weekly-build.yaml

@@ -1,13 +1,12 @@
 name: Weekly Build
-
-# Run every day at 23:00 UTC
 on: 
   schedule:
     - cron: "0 23 * * *"
 
 jobs:
   publish-image:
     runs-on: ubuntu-latest
+    timeout-minutes: 90
     steps:
       - name: Invoke Build on Operator Repo
         uses: benc-uk/workflow-dispatch@v1