Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_loop_wake_eventand ashutdown_requested_atmarker toOpsOrchestratorand updatedstart_loop/stop_loopto set the marker, setstop_event, and explicitly wake the loop before joining.time.sleep(0)) then attempt a grace join._tickby constructing theHealthSnapshotwhile holding the lock but emitting the snapshot after releasing the lock to avoid long critical sections._wake_loopand_emit_shutdown_heartbeathelpers so the loop emits one final heartbeat/log when it observesstop_event.main.pyshutdown handling to include whether the loop thread is still alive (is_loop_alive()) in the shutdown warning and to emit explicit follow-up guidance whenstop_loopreturnstimed_out.tests/covering timeout/warning behavior, lock contention handling, explicit wake + retry behavior, and final heartbeat emission, and adjustedtests/test_main_ops_shutdown_warning.pyto assert the new logging behavior.Testing
python -m pip install pyyaml -qwhich completed successfully.pytest -q tests/test_ops_orchestrator_shutdown.py tests/test_main_ops_shutdown_warning.pyand observed12 passed in 0.59s.Codex Task