Support devices that can't be reset from software #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some devices out there that can't be reset from software, and need a physical button pressed to put them into bootloader mode. On these devices, trying to reset them is not going to work, so it is best skipped. As such, this little change adds a `manualReset` flag to the board options, which when set, allows `Avr109._reset` to return immediately, skipping the whole reset dance. As a consequence, boards with the flag set, will have to be reset by the user before calling the `_upload` (or `avrgirl.flash`) method. Tested & works on the Shortcut keyboard, and fixes #111. Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
Owner
|
Hi @algernon! This is a rad addition to avrgirl-arduino! Thank you so much for taking the time to learn the codebase in order to contribute. I have merged this, with a couple of extra checks around the flag, along with some brief documentation in the README. That Shortcut keyboard is really cool! ✨ |
Contributor
Author
|
Whoops, sorry for missing the instance options! Should've thought of that, too. Thanks for taking the patch nevertheless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some devices out there that can't be reset from software, and need a physical button pressed to put them into bootloader mode. On these devices, trying to reset them is not going to work, so it is best skipped.
As such, this little change adds a
manualResetflag to the board options, which when set, allowsAvr109._resetto return immediately, skipping the whole reset dance. As a consequence, boards with the flag set, will have to be reset by the user before calling the_upload(oravrgirl.flash) method.Tested & works on the Shortcut keyboard, and fixes #111.
Please let me know if you don't like the name of the flag - or anything else with the pull request - and I'll update it accordingly!