Integrate travis coveralls and houndci #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 4, 2018
tests/example.spec.js
Outdated
| @@ -0,0 +1,14 @@ | |||
| import chai from 'chai'; | |||
|
|
|||
| const should = chai.should(); | |||
There was a problem hiding this comment.
'should' is assigned a value but never used no-unused-vars
| @@ -0,0 +1,14 @@ | |||
| import chai from 'chai'; | |||
There was a problem hiding this comment.
Unable to resolve path to module 'chai' import/no-unresolved
Missing file extension for "chai" import/extensions
Collaborator
There was a problem hiding this comment.
You can try to add this to .eslintrc to fix this:
"settings": {
"import/resolver": {
"node": {
"extensions": [".js",".jsx"]
}
}
}
Owner
Author
There was a problem hiding this comment.
I've added this and it's still not working. Help me check the .eslintrc to see if I've added it correctly.
- add .hound.yml and .travis.yml files - install mochas, nyc and chai - write a sample test - add npm test to package.json [Finishes #156465076]
noordean
force-pushed
the
ch-integrate-travis-coveralls-houndci-156465076
branch
from
acd7a29 to
490b012
Compare
houndci-bot
reviewed
Apr 5, 2018
| @@ -0,0 +1,14 @@ | |||
| import chai from 'chai'; | |||
There was a problem hiding this comment.
Unable to resolve path to module 'chai' import/no-unresolved
Missing file extension for "chai" import/extensions
phemmz
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.