Skip to content

Conversation

@noordean
Copy link
Owner

No description provided.

- add sequelize, sequelize-cli and mysql2 packages
- create migration for Item

[Finishes #156304277]
}
});

db.sequelize = sequelize;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'sequelize' used outside of binding context block-scoped-var

db[model.name] = model;
});

Object.keys(db).forEach(function(modelName) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected unnamed function func-names
Unexpected function expression prefer-arrow-callback
Missing space before function parentheses space-before-function-paren

return (file.indexOf('.') !== 0) && (file !== basename) && (file.slice(-3) === '.js');
})
.forEach(function(file) {
var model = sequelize['import'](path.join(__dirname, file));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected var, use let or const instead no-var
'sequelize' used outside of binding context block-scoped-var
["import"] is better written in dot notation dot-notation

.filter(function(file) {
return (file.indexOf('.') !== 0) && (file !== basename) && (file.slice(-3) === '.js');
})
.forEach(function(file) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected function expression prefer-arrow-callback
Unexpected unnamed function func-names
Missing space before function parentheses space-before-function-paren

fs
.readdirSync(__dirname)
.filter(function(file) {
return (file.indexOf('.') !== 0) && (file !== basename) && (file.slice(-3) === '.js');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 20 exceeds the maximum line length of 80 max-len

var fs = require('fs');
var path = require('path');
var Sequelize = require('sequelize');
var basename = path.basename(module.filename);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected var, use let or const instead no-var
Multiple spaces found before '=' no-multi-spaces


var fs = require('fs');
var path = require('path');
var Sequelize = require('sequelize');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected var, use let or const instead no-var
Expected 1 empty line after require statement not followed by another require import/newline-after-import
Unable to resolve path to module 'sequelize' import/no-unresolved

'use strict';

var fs = require('fs');
var path = require('path');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected var, use let or const instead no-var
Multiple spaces found before '=' no-multi-spaces

@@ -0,0 +1,36 @@
'use strict';

var fs = require('fs');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected var, use let or const instead no-var
Multiple spaces found before '=' no-multi-spaces

@@ -0,0 +1,36 @@
'use strict';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'use strict' is unnecessary inside of modules strict

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6: 0.0%
Covered Lines: 8
Relevant Lines: 8

💛 - Coveralls

@noordean noordean merged commit 563c883 into develop Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants