Merged
Conversation
execution would not cancel the operation itself and would not call super implementation of -cancel method.
Fix/set state thread safety
Finish operation when cancelling already running operation
Add missing context parameter when removing observer
Add convenience method to add multiple operations into group operation
Fixes issue when cancelling alert operation prior to operation
…itions; Updated location and notification conditions to use `alertPresentationExclusivity`
…etState:` - Turning off automatic notification of changes for `state` on `OPOperation` - Moves KVO change notification methods within the `@syncronized` block / within the guarding if check for state not equal to finished. This resolves some issues around thread safety in regards to state changes as well as KVO notifications on state change being called when it shouldn’t be.
Adds media permission operation and audio/video conditions
…parameter Add parameter name to fix Xcode autocompletion issues
Moving call for KVO changes into `@synchronized` on `OPOperation` `-setState:`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.