Skip to content

[WIP] Investigate and resolve TODO for user and blog creation#150

Closed
Claude wants to merge 2 commits into
autopilotfrom
claude/address-todo-in-ms-functions-again
Closed

[WIP] Investigate and resolve TODO for user and blog creation#150
Claude wants to merge 2 commits into
autopilotfrom
claude/address-todo-in-ms-functions-again

Conversation

@Claude
Copy link
Copy Markdown

@Claude Claude AI commented Apr 15, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>Address TODO in wp-includes/ms-functions.php: : What to do if we create a user but cannot create a blog?</issue_title>
<issue_description>Found a @todo comment that needs attention.

File: src/wp-includes/ms-functions.php
Line: 1265
Comment: : What to do if we create a user but cannot create a blog?

Investigate, implement if appropriate, and include tests.
If no longer relevant, remove it and explain why.</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

…failure

Resolves orphaned user accounts when blog creation fails during multisite signup
activation. The function now:
- Deletes newly created users when blog creation fails (non-blog_taken errors)
- Preserves pre-existing users by checking $user_already_exists flag
- Cleans user cache after deletion to prevent stale data
- Maintains backward compatibility with blog_taken error handling

Includes comprehensive test coverage for all scenarios:
- New user deletion on blog creation failure
- Existing user preservation on blog creation failure
- blog_taken error handling with user preservation
- Successful activations
- User-only signups
- Cache cleanup verification

Agent-Logs-Url: https://github.com/nopilots/wordpress-develop/sessions/64f52a37-c9e9-473b-a100-1dac16b4d0e8

Co-authored-by: josephfusco <6676674+josephfusco@users.noreply.github.com>
@Claude Claude AI requested a review from josephfusco April 15, 2026 08:33
@github-actions github-actions Bot added the safety:halt Circuit breaker active label Apr 15, 2026
@josephfusco
Copy link
Copy Markdown

Closing as part of a system simplification.

The pipeline has been stuck for 7 days with no merges. Root causes identified: revision chains, work-generation workflows, test-failures bypassing approval gates, and workflow self-modification noise.

A clean-slate cleanup is in progress. The system will resume with a tighter, simpler workflow set. Fresh PRs from agents will flow through the corrected pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safety:halt Circuit breaker active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address TODO in wp-includes/ms-functions.php: : What to do if we create a user but cannot create a blog?

2 participants