Skip to content

[WIP] Fix TODO in ms-functions.php to use *_url() API#151

Closed
Claude wants to merge 2 commits into
autopilotfrom
claude/address-todo-in-ms-functions-another-one
Closed

[WIP] Fix TODO in ms-functions.php to use *_url() API#151
Claude wants to merge 2 commits into
autopilotfrom
claude/address-todo-in-ms-functions-another-one

Conversation

@Claude
Copy link
Copy Markdown

@Claude Claude AI commented Apr 15, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>Address TODO in wp-includes/ms-functions.php: Use *_url() API.</issue_title>
<issue_description>Found a @todo comment that needs attention.

File: src/wp-includes/ms-functions.php
Line: 973
Comment: Use *_url() API.

Investigate, implement if appropriate, and include tests.
If no longer relevant, remove it and explain why.</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

- Replace hardcoded http:// with set_url_scheme() in activation URL
- Ensures proper HTTPS handling when is_ssl() returns true
- Adds comprehensive test coverage for URL construction
- Resolves TODO at wp-includes/ms-functions.php:973

Agent-Logs-Url: https://github.com/nopilots/wordpress-develop/sessions/05e67b39-126f-491a-bd78-086a8ce127b9

Co-authored-by: josephfusco <6676674+josephfusco@users.noreply.github.com>
@Claude Claude AI requested a review from josephfusco April 15, 2026 10:14
@github-actions github-actions Bot added the safety:halt Circuit breaker active label Apr 15, 2026
@josephfusco
Copy link
Copy Markdown

Closing as part of a system simplification.

The pipeline has been stuck for 7 days with no merges. Root causes identified: revision chains, work-generation workflows, test-failures bypassing approval gates, and workflow self-modification noise.

A clean-slate cleanup is in progress. The system will resume with a tighter, simpler workflow set. Fresh PRs from agents will flow through the corrected pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safety:halt Circuit breaker active

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address TODO in wp-includes/ms-functions.php: Use *_url() API.

2 participants