Fix Memory Leak in ExampleSideMenuViewController#2
Merged
noppefoxwolf merged 1 commit intoOct 26, 2024
Conversation
Owner
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number
#1
Implementation Summary
This PR fixes the memory leak issue that occurred in the
ExampleSideMenuViewController. The issue was caused by a strong reference by theanimator.onTapDimmingView.To resolve this, the code introduces weak references to the presented view controller inside the closures assigned to
animator.onTapDimmingView. This ensures that the presented view controller can be properly deallocated when dismissed.Reference
Screen.Recording.2024-10-26.at.3.46.59.PM.mov