Skip to content

Implement #641 for AWS resources (info about template being marked as IMPORT_ONLY#642

Merged
smoy merged 1 commit intonoqdev:mainfrom
smoy:feat/641-warn-about-import-only-templates
Sep 19, 2023
Merged

Implement #641 for AWS resources (info about template being marked as IMPORT_ONLY#642
smoy merged 1 commit intonoqdev:mainfrom
smoy:feat/641-warn-about-import-only-templates

Conversation

@smoy
Copy link
Copy Markdown
Collaborator

@smoy smoy commented Sep 19, 2023

What changed?

  • info about template being marked as IMPORT_ONLY

Rationale

  • Sometimes user change template that is marked as import_only, and they may be debugging why an explicit change locally doesn't produce any changes. Log the info to help the user reminder about the changed resource is marked as IMPORT_ONLY already.

How was it tested?

If it was manually verified, list the instructions for your reviewers to follow.

  • Unit Tests
  • Functional Tests
  • Manually Verified
(env) smoy@Stevens-MacBook-Pro smoy-iambic % iambic plan resources/aws/iam/user/iambic-tutorial-aws-mgmt/debug_iam_user.yaml
2023/09/19 09:04:56 [info     ] Loading config...
2023/09/19 09:04:56 [info     ] Setting config metadata...
2023/09/19 09:04:59 [info     ] Plugins loaded successfully...
2023/09/19 09:04:59 [info     ] Scanning for expired resources
2023/09/19 09:05:00 [info     ] Expired resource scan complete.
2023/09/19 09:05:02 [info     ] Resource is marked as import only. 
  resource_id=debug_iam_user 
  resource_type=aws:iam:user
2023/09/19 09:05:02 [info     ] Finished scanning for changes.
IAMbic Summary

Change Detection

* 0 templates with changes.
* 0 accounts affected.

@smoy smoy self-assigned this Sep 19, 2023
Copy link
Copy Markdown
Contributor

@castrapel castrapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smoy smoy merged commit cfeef7d into noqdev:main Sep 19, 2023
@smoy smoy deleted the feat/641-warn-about-import-only-templates branch September 19, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants