fix: editor groups border can't be transparent#104
Merged
arcticicestudio merged 1 commit intoMar 23, 2019
Merged
Conversation
Fix tab moving in split view
arcticicestudio
added
type-bug
status-requires-review
hacktoberfest
arcticicestudio
removed
hacktoberfest
arcticicestudio
approved these changes
Mar 23, 2019
Contributor
arcticicestudio
left a comment
arcticicestudio
left a comment
There was a problem hiding this comment.
Hi @mdogadailo 👋, thanks for your contribution 👍
Sorry for the long delay, I've been really busy with my job, real life and Nord's, finally launched, official website and documentation.
It's a bit strange that a color affects VS Code's tab drag & drop behaviour, but I've tested your changes and it works fine.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #98 tab moving in split view.
Field
editorGroup.bordercan't be (well it can but it breaks some things) because vscode splitview remove separator class.I've changed its alpha to 1% which is still not visible for human eye but fix this issue.